Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): Add the ticks variant #1104

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

MarkoOleksiyenko
Copy link
Contributor

No description provided.

@MarkoOleksiyenko MarkoOleksiyenko force-pushed the slider-ticks branch 2 times, most recently from 31e16dd to 3aeb903 Compare February 12, 2025 12:31
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.23%. Comparing base (915f6cf) to head (e7dc988).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
react/bootstrap/src/components/slider/slider.tsx 77.77% 0 Missing and 2 partials ⚠️
...ootstrap/src/components/slider/slider.component.ts 75.00% 1 Missing ⚠️
core/src/components/slider/slider.ts 97.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
+ Coverage   91.21%   91.23%   +0.01%     
==========================================
  Files          99       99              
  Lines        2710     2761      +51     
  Branches      446      457      +11     
==========================================
+ Hits         2472     2519      +47     
- Misses        156      157       +1     
- Partials       82       85       +3     
Flag Coverage Δ
e2e 83.04% <92.85%> (+0.21%) ⬆️
unit 84.09% <76.74%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarkoOleksiyenko MarkoOleksiyenko force-pushed the slider-ticks branch 9 times, most recently from 77ba539 to 28b235f Compare February 18, 2025 08:55
@MarkoOleksiyenko MarkoOleksiyenko marked this pull request as ready for review February 18, 2025 09:33
@MarkoOleksiyenko MarkoOleksiyenko force-pushed the slider-ticks branch 4 times, most recently from c9ec052 to a88392f Compare February 25, 2025 10:38
@MarkoOleksiyenko MarkoOleksiyenko force-pushed the slider-ticks branch 2 times, most recently from 7fa36d6 to baaa927 Compare February 25, 2025 14:01
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkoOleksiyenko MarkoOleksiyenko merged commit ff9034c into AmadeusITGroup:main Feb 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider]: allow possible step look on the horizontal / vertical bar to identify better the range.
3 participants