Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): handle focus in range #1118

Merged

Conversation

quentinderoubaix
Copy link
Contributor

No description provided.

@quentinderoubaix quentinderoubaix enabled auto-merge (squash) February 28, 2025 10:40
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.19%. Comparing base (ff9034c) to head (5ec1b39).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ootstrap/src/components/slider/slider.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   91.23%   91.19%   -0.04%     
==========================================
  Files          99       99              
  Lines        2761     2761              
  Branches      457      457              
==========================================
- Hits         2519     2518       -1     
- Misses        157      158       +1     
  Partials       85       85              
Flag Coverage Δ
e2e 83.00% <75.00%> (-0.04%) ⬇️
unit 84.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MarkoOleksiyenko MarkoOleksiyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @quentinderoubaix !

@quentinderoubaix quentinderoubaix merged commit 8839248 into AmadeusITGroup:main Feb 28, 2025
15 of 16 checks passed
@quentinderoubaix quentinderoubaix deleted the fix-e2e-angular branch February 28, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants