reduce unnecessary unmarshal (argoproj#17187)

Signed-off-by: Wilson Wang <wilson.wang@bytedance.com>
AmadeusITGroup · Jun 16, 2024 · e239215 · e239215
1 parent 95fbc6d
commit e239215
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/controller/appcontroller.go b/controller/appcontroller.go
@@ -510,13 +510,13 @@ func (ctrl *ApplicationController) getResourceTree(a *appv1.Application, managed
 		if err != nil {
 			return nil, fmt.Errorf("failed to unmarshal live state of managed resources: %w", err)
 		}
-		var target = &unstructured.Unstructured{}
-		err = json.Unmarshal([]byte(managedResource.TargetState), &target)
-		if err != nil {
-			return nil, fmt.Errorf("failed to unmarshal target state of managed resources: %w", err)
-		}
 
 		if live == nil {
+			var target = &unstructured.Unstructured{}
+			err = json.Unmarshal([]byte(managedResource.TargetState), &target)
+			if err != nil {
+				return nil, fmt.Errorf("failed to unmarshal target state of managed resources: %w", err)
+			}
 			nodes = append(nodes, appv1.ResourceNode{
 				ResourceRef: appv1.ResourceRef{
 					Version:   target.GroupVersionKind().Version,