Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Localisation builders UTs are failing on CI #1207

Closed
kpanot opened this issue Jan 12, 2024 · 1 comment · Fixed by #1276
Closed

[Bug]: Localisation builders UTs are failing on CI #1207

kpanot opened this issue Jan 12, 2024 · 1 comment · Fixed by #1276
Labels
bug Something isn't working

Comments

@kpanot
Copy link
Contributor

kpanot commented Jan 12, 2024

Package name

localization

Package version

10.0.*

Reproduction steps

Run skipped Localization's builders UTs.

Current result

Instability of the UT based on Virtual Filesystem on Github CI (Linux and Windows)

Expected result

UT to pass on CI

Additional comments

No response
@kpanot kpanot added the bug Something isn't working label Jan 12, 2024
@kpanot kpanot changed the title [Bug]: [Bug]: Localisation builders UTs are failing on CI Jan 12, 2024
@fpaul-1A
Copy link
Contributor

The tests have been re-enabled with PR #1276
We should no longer have timeouts with the use of advanceTimers: true in fakeTimers config

@fpaul-1A fpaul-1A linked a pull request Jan 30, 2024 that will close this issue
test: rework unit tests to separate dom and node tests #1276
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: rework unit tests to separate dom and node tests AmadeusITGroup/otter
2 participants
@kpanot @fpaul-1A