test: rework unit tests to separate dom and node tests #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpaul-1A
force-pushed
the
test/ut-rework
branch
from
9f73632 to
f8e4758
Compare
github-actions
bot
added
project:@ama-sdk/core
project:@ama-sdk/schematics
project:@ama-sdk/showcase-sdk
project:@ama-terasu/cli
project:@ama-terasu/core
project:@ama-terasu/schematics
project:@o3r/amaterasu-api-spec
project:@o3r/amaterasu-dodo
project:@o3r/amaterasu-otter
project:@o3r/amaterasu-sdk
project:@o3r/analytics
project:@o3r/apis-manager
project:@o3r/application
project:@o3r/artifactory-tools
project:@o3r/azure-tools
project:@o3r/chrome-devtools
project:@o3r/components
project:@o3r/configuration
project:@o3r/design
project:@o3r/dev-tools
project:@o3r/dynamic-content
project:@o3r/eslint-plugin
project:@o3r/extractors
project:@o3r/forms
project:@o3r/github-cascading-app
project:@o3r/localization
project:@o3r/logger
labels
kpanot
previously approved these changes
Jan 29, 2024
fpaul-1A
force-pushed
the
test/ut-rework
branch
from
215a5da to
45f8e76
Compare
fpaul-1A
force-pushed
the
test/ut-rework
branch
from
45f8e76 to
aeed357
Compare
fpaul-1A
force-pushed
the
test/ut-rework
branch
from
aeed357 to
8cf6b98
Compare
matthieu-crouzet
previously approved these changes
Jan 29, 2024
fpaul-1A
force-pushed
the
test/ut-rework
branch
5 times, most recently
from
5ab39f3 to
1880f2c
Compare
matthieu-crouzet
previously approved these changes
Jan 29, 2024
fpaul-1A
force-pushed
the
test/ut-rework
branch
from
1880f2c to
66840f0
Compare
matthieu-crouzet
previously approved these changes
Jan 29, 2024
fpaul-1A
force-pushed
the
test/ut-rework
branch
from
66840f0 to
84152f3
Compare
matthieu-crouzet
approved these changes
Jan 30, 2024
cpaulve-1A
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently, we only have 1 jest config for all unit-tests
Unfortunately, the tests for
srcusually don't require the same environment as the tests forschematicsandbuildersThe idea is to have a different project for each (check
packages/@o3r/core/jest.config.ts)This will fix the tests issue on #1255 and #1243
Related issues