fix: increase test time limit for schematics #1291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpanot
changed the title
github-actions
bot
added
bug
fpaul-1A
reviewed
Jan 29, 2024
| @@ -78,7 +78,7 @@ describe('Typescript Shell Generator', () => { | |||
| skipInstall: true, | |||
| packageManager: 'npm' | |||
| }, Tree.empty()); | |||
| }, 15000); | |||
| }, 25000); | |||
There was a problem hiding this comment.
In my PR about reworking the unit tests, I've increased the global testTimeout to 30s https://github.com/AmadeusITGroup/otter/pull/1276/files#diff-cacec94ff84332c24eff579dc017461bb1cd2caf48ef3a408a70ecbcff09738eR74 and removed this specific timeout https://github.com/AmadeusITGroup/otter/pull/1276/files#diff-4ea0cb94662b0faa9ea84bf4c618eaad8b69afeb89c46d38f3c4aaad20a89f1cL81
There was a problem hiding this comment.
then i flag it duplicate of #1276
fpaul-1A
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.