Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ng g application with yarn 1 #1247

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix: ng g application with yarn 1 #1247

merged 1 commit into from
Jan 19, 2024

Conversation

vscaiceanu-1a
Copy link
Member

@vscaiceanu-1a vscaiceanu-1a commented Jan 18, 2024

Proposed change

Today, with yarn 1

yarn create @o3r my-workspace
cd my-workspace
yarn ng g application my-app

we get:

✔ Packages installed successfully.
error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check).
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
✖ Package install failed, see above.
The Schematic workflow failed. See above.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@kpanot
Copy link
Contributor

kpanot commented Jan 18, 2024

missing a pipeline based on yarn 1 to test the content of this :S.

@vscaiceanu-1a
Copy link
Member Author

missing a pipeline based on yarn 1 to test the content of this :S.

We are far from having a working CI for end-to-end test with yarn 1. That is the goal of #1230

The goal of this PR is to allow users at least to be able to generate a first application within a monorepo while using yarn 1.

@vscaiceanu-1a vscaiceanu-1a added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 3462fc3 Jan 19, 2024
24 checks passed
@vscaiceanu-1a vscaiceanu-1a deleted the bugfix/ng-g-yarn1 branch January 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants