chore: upgrade version of Design Factory #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpanot
force-pushed
the
chore/upgrade-df
branch
from
60c307b
to
a79a698
Compare
kpanot
force-pushed
the
chore/upgrade-df
branch
2 times, most recently
from
019f452
to
f9941c1
Compare
fpaul-1A
reviewed
Sep 12, 2024
| @@ -93,7 +96,7 @@ | |||
| { | |||
| "type": "initial", | |||
| "maximumWarning": "500kb", | |||
| "maximumError": "2mb" | |||
| "maximumError": "2.5mb" | |||
fpaul-1A
reviewed
Sep 12, 2024
kpanot
force-pushed
the
chore/upgrade-df
branch
from
f9941c1
to
7c6dd09
Compare
fpaul-1A
reviewed
Sep 12, 2024
kpanot
force-pushed
the
chore/upgrade-df
branch
2 times, most recently
from
5bfbbaa
to
02ef53e
Compare
fpaul-1A
previously approved these changes
Sep 12, 2024
vscaiceanu-1a
previously approved these changes
Sep 12, 2024
Nop, I knew there were issue in their migration script so I did not run it, |
kpanot
force-pushed
the
chore/upgrade-df
branch
from
02ef53e
to
6ea7331
Compare
fpaul-1A
approved these changes
Sep 13, 2024
| @@ -48,6 +48,7 @@ | |||
| * Zone JS is required by default for Angular itself. | |||
| */ | |||
| import 'zone.js'; // Included with Angular CLI. | |||
| import '@angular/localize/init'; | |||
There was a problem hiding this comment.
Why do we need that ?
| "polyfills": ["zone.js"], | ||
| "polyfills": [ | ||
| "zone.js", | ||
| "@angular/localize/init" |
There was a problem hiding this comment.
same comment here
matthieu-crouzet
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues