feat(eslint): ng-add eslint-config #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f1f4448. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
fpaul-1A
reviewed
Sep 18, 2024
github-actions
bot
added
enhancement
matthieu-crouzet
force-pushed
the
feat/ng-add-eslint-config
branch
from
605cb8d
to
76d699a
Compare
fpaul-1A
approved these changes
Sep 18, 2024
kpanot
reviewed
Sep 18, 2024
matthieu-crouzet
force-pushed
the
feat/ng-add-eslint-config
branch
from
76d699a
to
f1f4448
Compare
kpanot
approved these changes
Sep 20, 2024
matthieu-crouzet
merged commit bedabcf
into
feat/migrate-eslint-9-flat-config
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
ng-addof the@o3r/eslint-configpackageNote
This PR is not targetting
main.I will create a PR for
mainonce everything below will be merged onfeat/migrate-eslint-9-flat-configWill be done in others PRs:
@o3r/coreng-add to install@o3r/eslint-configor@o3r/eslint-config-otterdepending on ESLint configuration found (FlatConfig or LegacyConfig)@o3r/eslint-config(fixjsdoc/check-examples)