Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: github-action package not working #2637

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: github-action package not working #2637

merged 1 commit into from
Dec 20, 2024

Conversation

fpaul-1A
Copy link
Contributor

Proposed change

Related issues

- No issue associated -

@fpaul-1A fpaul-1A requested a review from a team as a code owner December 19, 2024 17:15
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 19, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 52e1c1c.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 4m 46s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 1m 52s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 35s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 18s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 7s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx affected --target=lint --base=remotes/origin... ✅ Succeeded 25s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 17:34:18 UTC

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (fae0dd1) to head (52e1c1c).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matthieu-crouzet
matthieu-crouzet reviewed Dec 20, 2024
View reviewed changes
.github/workflows/code-check.yml
- name: Package github actions
env:
nxCmd: ${{ inputs.affected && format('nx affected --base=remotes/origin/{0}', github.base_ref || github.ref_name) || 'nx run-many'}}
run: yarn ${{ env.nxCmd }} --target=package-github-action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check after this command that any files from tools/github-actions/*/packaged-action/** has been modified ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure the package action is stable enough? we had to revert changes made by it a few times
we can still do that in a future PR and merge this one to unblock the precommit

@fpaul-1A fpaul-1A added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 88b7d37 Dec 20, 2024
37 of 38 checks passed
@fpaul-1A fpaul-1A deleted the fix/github-action-package branch December 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-crouzet matthieu-crouzet matthieu-crouzet left review comments

@cpaulve-1A cpaulve-1A cpaulve-1A approved these changes

@kpanot kpanot kpanot approved these changes

Assignees
No one assigned
Labels
bug Something isn't working project:new-version-gh-action project:@o3r/new-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fpaul-1A @kpanot @matthieu-crouzet @cpaulve-1A