Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workspace): update nx scope in generated executors #2717

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix(workspace): update nx scope in generated executors #2717

merged 1 commit into from
Jan 27, 2025
+2 −2

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Jan 22, 2025

Proposed change

fix(workspace): update nx scope in generated executors

Related issues

- No issue associated -

@kpanot kpanot requested a review from a team as a code owner January 22, 2025 07:24
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 721f076.

Command Status Duration Result
nx run-many --target=test-e2e ✅ Succeeded 9m 7s View ↗
nx run-many --target=test-int ✅ Succeeded 4s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 1m 51s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 18s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded <1s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded 25s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-27 03:08:03 UTC

@github-actions github-actions bot added bug Something isn't working project:@o3r/workspace labels Jan 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.33%. Comparing base (b6b0ae6) to head (6054182).

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpaul-1A fpaul-1A mentioned this pull request Jan 24, 2025
Merged
@kpanot kpanot force-pushed the bugfix/workspace-nx branch from 6054182 to 721f076 Compare January 27, 2025 02:51
matthieu-crouzet
matthieu-crouzet reviewed Jan 27, 2025
View reviewed changes
packages/@o3r/workspace/schematics/library/templates/nx/project.json.template
@@ -34,7 +34,7 @@
}
},
"lint": {
"executor": "@nrwl/linter:eslint",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use this executor as it does not support mjs (at least when we did the migration to ESLint v9 and flat config)

Copy link
Contributor Author

@kpanot kpanot Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The origin the PR were made to fix the @nrwl/jest:jest which is still used.
I fixed the @nrwl/linter:eslint because it was also invalid.
I create the issue #2735 to handle the migration to eslint cli execution.

@kpanot kpanot added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 5bf474a Jan 27, 2025
28 checks passed
@kpanot kpanot deleted the bugfix/workspace-nx branch January 27, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@matthieu-crouzet matthieu-crouzet matthieu-crouzet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working project:@o3r/workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpanot @matthieu-crouzet @fpaul-1A