fix: build builder and schematics for o3r lib #2727
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 2dbf6c7.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
vscaiceanu-1a
force-pushed
the
fix/add-lib-scripts
branch
2 times, most recently
from
a526289 to
218ffa6
Compare
kpanot
reviewed
Jan 23, 2025
| @@ -31,11 +31,12 @@ Otherwise, use the error message as guidance.`); | |||
| * @param options | |||
| */ | |||
| function ngAddFn(options: NgAddSchematicsSchema): Rule { | |||
| return async (tree, context) => { | |||
| return async (tree, _context) => { | |||
There was a problem hiding this comment.
Suggested change
| return async (tree, _context) => { | |
| return async (tree) => { |
| const tsConfig = ts.parseConfigFileTextToJson('/tsconfig.json', tree.readText('/tsconfig.json')).config; | ||
| if (tsConfig.compilerOptions?.noPropertyAccessFromIndexSignature) { | ||
| delete tsConfig.compilerOptions.noPropertyAccessFromIndexSignature; | ||
| const tsConfigPath = '/tsconfig.json'; |
There was a problem hiding this comment.
should not be instead something like:
Suggested change
| const tsConfigPath = '/tsconfig.json'; | |
| const tsConfigPath =['/tsconfig.lib.json', '/tsconfig.app.json', '/tsconfig.json'].filter((file) => tree.exists(file)); |
and run on all the file found?
There was a problem hiding this comment.
this is only about the root tsconfig file so there won't be app/lib ones
There was a problem hiding this comment.
waiting for #2648 to be merged and to adapt this PR
vscaiceanu-1a
force-pushed
the
fix/add-lib-scripts
branch
from
218ffa6 to
c80db98
Compare
vscaiceanu-1a
force-pushed
the
fix/add-lib-scripts
branch
from
c80db98 to
2dbf6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues
- No issue associated -