Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak #6

Closed
PapiOphidian opened this issue Sep 17, 2021 · 6 comments
Closed

Memory Leak #6

PapiOphidian opened this issue Sep 17, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@PapiOphidian
Copy link
Member

There is a current memory leak I'm investigating. I believe queues are not being properly removed or destroyed. I'll be waiting for memory usage to go high and then take a heapdump to find the issue
@PapiOphidian PapiOphidian added the bug Something isn't working label Sep 17, 2021
@PapiOphidian
Copy link
Member Author

This is a leak within the threads

@PapiOphidian
Copy link
Member Author

This is a leak where songs are not being destroyed entirely properly

@PapiOphidian
Copy link
Member Author

This is an issue with Prism-media when tracks are set to have inline volume

@PapiOphidian
Copy link
Member Author

This will have a temporary fix in the next update where infinite threads spawn instead of having a set number based on cpu core count and having theoretically infinite uptime so long as queues are being added to keep the worker alive

@PapiOphidian
Copy link
Member Author

Partial fix in dd23c79

@PapiOphidian
Copy link
Member Author

Totally fixed in 5dc49a4
Removed dep on @discordjs/opus and swapped to opusscript. Issue resolved thanks to answer from discordjs/voice#197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PapiOphidian