chore!: re-do graphql schema snapshot testing #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous implementation we had the Jest test file in the package. This worked while we were running tests in silverback-mono. But Jest always ignores test files which path includes `node_modules`. So now the test file should be located in the tested project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package(s) involved
@amazeelabs/graphql-schema-testDescription of changes
In the previous implementation we had the Jest test file served with the package. This worked while we were running tests in silverback-mono. But Jest always ignores test files which path includes
node_modules. So now the test file should be located in the tested project.Motivation and context
It did not work in external projects.
Related Issue(s)
jestjs/jest#11781