-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'parsetiming' command #1046
Conversation
So the python failure is a weird segfault when
I think the issue here is some weirdness with conda, since I'm requesting the 3.8 environment but clearly getting conda with 3.11. I think this might be because the I think that to remedy this, I'm going to try to switch to |
Ugh. Using
But pytraj builds and tests fine locally for me with conda3/python 3.11. Since I can't reproduce the error I'm going to ignore it if everything else passes because this has already cost me a day of development time. |
@drroe I've triggered a PR in wondering what's the difference. |
I don't know, but the fact that it's pytest that dies makes it seem like CI is the problem, not cpptraj or pytraj. |
um, I force to use python 3.8 here but still getting the segmentation fault: https://github.com/Amber-MD/cpptraj/actions/runs/5895317440/job/15990821342 Meanwhile, the PR in pytraj is ok: https://github.com/Amber-MD/pytraj/actions/runs/5894734864/job/15988988772 I am wondering if the segmentation fault comes from your current change or not (If yes, the CI actually does the job catching it). |
oh wait, I was dumb. I think this PR does not have your new change yet. lol. #1047 trying to find out what the difference between pytraj and cpptraj github action setups. |
Except I can't reproduce the bug locally (conda 23.3.1, python 3.11.4). It only crashes on GitHub. |
@drroe Please merge my change here to yours: #1047 So the difference here that The change in #1047 will make sure |
Thanks Hai, I'll give it a try |
finally ... |
It WORKED, thanks so much @hainm! This is a really good illustration of my frustration with python. A random segfault on CI that can't be reproduced locally (even with ostensibly the same setup) that goes away simply by changing environments. It seems to happen quite often with python and it makes python development very frustrating. Which is why I'm very glad to have someone like @hainm along who can help untangle these python knots. Cheers! |
yeah, I am here to hold hand. :D |
Version 6.20.3. Adds the
parsetiming
command, which can be used to extract and report CPPTRAJ timing data from CPPTRAJ output. Intended for use in benchmarking. Updates the manual and adds a test.