-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add energy decomposition (with PME) #1109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERFC non-const and put timing tracking directly into ErfcFxn
… for regular Ewald yet.
rewrite of the Ewald classes.
to be used by PairDist and EnergyDecomposer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 6.29.4.
Adds a new action command,
enedecomp
, which allows per-atom energy decomposition of a system:To make this work well under the hood and to avoid unnecessary duplication of code from the
energy
action, the entire Ewald framework was rewritten. There is also now a template class calledPairListTemplate
which can be assigned an "engine" class which should simplify (I hope) usage of pair lists going forward and replaces (and should be more robust than) the old hacky include/define framework (PairListLoop.h
). I also managed to get about a 30% speedup over the old serial code for PME (so yay!).The cool thing about this is that thanks to @andysim 's helPME library, we can fully decompose the nonbonded energies with PME, which is something that I think even SANDER doesn't do. I don't quite have the LJ PME decomposition fully working yet (I'm doing something wrong with the reciprocal term) but that's coming soon. This ended up taking about twice as long as I wanted to, but I think it will be worth it in the long run.
This can be sped up both via OpenMP and MPI. Adds a test, updates the manual.