Add Decals example #347
Merged
Add Decals example #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikNoren
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Awesome work! Yeah leaving the decal component as is makes sense.
I can see that there's some issue with decal rendering in general though; it should only be visible inside of the green box. But I think that's a separate issue from just exposing the functionality to the guest side, so we can merge this and then create a separate issue for fixing decals in general. (I also see that the problem exists in the native decal example).
There was a problem hiding this comment.
This file isn't used right?
There was a problem hiding this comment.
This is used for the example at crates/decals/examples/decals.rs and was missing
|
Created an issue for the rendering issue here: #352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I need feedback and code review on this PR. This addresses #292 I added a new
decal_from_urlcomponent per @FredrikNoren suggestion at:https://discord.com/channels/894505972289134632/1078283561540530216/1096581219925377195
The example seems to render okay:
I suspect this can be cleaned up or migrated. I left the old
decalcomponent in the code because there were other crates that were dependent on it like the prefab. Not sure how to decouple or migrate the other crates. Please offer some guidance.