Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add(shared api): set_animation_blend, get_animation_clips, has_animation_clip #362

Merged
merged 3 commits into from
May 4, 2023
Merged

Add(shared api): set_animation_blend, get_animation_clips, has_animation_clip #362

merged 3 commits into from
May 4, 2023

Conversation

devjobe
Copy link
Contributor

@devjobe devjobe commented May 3, 2023

A bit of rushed API changes for manual animation blending and updated the skinmesh example to show usage.

I don't think they are particularly good. I'd rather see a command based blending API but maybe it's good enough for 0.2.

  • set_animation_blend: Shared api, sets weights and time, both as optional. Time is either absolute or percentage.
  • has_animation_clip: Returns true when the asset cache has resolved an animation clip
  • get_animation_clips: Get duration and binder ids. This one is questionable. I guess retargeting should be accounted for
  • skinmesh example updates: Blending and time scrubbing

@philpax philpax requested a review from FredrikNoren May 3, 2023 11:26
Copy link
Contributor

@FredrikNoren FredrikNoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left some suggestions for improvements

crates/wasm/wit/entity.wit Outdated Show resolved Hide resolved
crates/wasm/wit/entity.wit Outdated Show resolved Hide resolved
@philpax philpax merged commit 3fa5915 into AmbientRun:main May 4, 2023
philpax added a commit that referenced this pull request May 23, 2023
Add(shared api): set_animation_blend, get_animation_clips, has_animation_clip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants