Correct type hint of def track(obj_field=) #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I upgraded pghistory, PyCharm showed me a type error that None is not expected, when it actually is one of the allowed types. I can surpress this inspection for the entire class, but that is overkill. A correct type hint would be preferable, since None is a valid value and necessary for M2M table add/remove tracking.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I upgraded pghistory, PyCharm showed me a type error that None is not expected, when it actually is one of the allowed types. I can surpress this inspection for the entire class, but that is overkill. A correct type hint would be preferable, since None is a valid value and necessary for M2M table add/remove tracking.