INTERACTIVE LIST #4
Conversation
Amedzro-Elikplim
commented
Feb 27, 2022
Amedzro-Elikplim
commented
- Change completed status of the list on check
- Clear all lists on click
There was a problem hiding this comment.
Hi @Amedzro-Elikplim, 👋🏻
Good job so far! 👍🏻
There are some issues that you still need to work on to go to the next project but you are almost there!
These changes aim to add some awesomeness to your awesome project and code skills.
To Highlight ✔️
Highly organized and clean code ✔️ 👨🏻💻
Professional documentation ✔️
Correct workflow ✔️
Meaningful commit messages ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| } | ||
|
|
||
| delete(description) { | ||
| this.array = JSON.parse(localStorage.getItem('tasks')); | ||
| const index = this.array.findIndex((item) => item.description === description); | ||
|
|
||
| this.updateIndex(index); |
There was a problem hiding this comment.
- Let's make sure our
clear completedis working as intented "removes only checked tasks" currently it removes all tasks. let's fix that
There was a problem hiding this comment.
Thanks, @Amrhub , actually I missed that part of the instructions. Thanks for pointing it out
There was a problem hiding this comment.
Approved 💯 ✅ 🥳 🎈 🎉
Hi @Amedzro-Elikplim, 👋🏻
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights ✅
Highly organized and clean code ✔️ 👨🏻💻
Professional documentation ✔️
Correct workflow ✔️
Meaningful commit messages ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
