Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to list devices. #16

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add feature to list devices. #16

merged 1 commit into from
Jan 13, 2023

Conversation

Wind-stormger
Copy link
Contributor

No description provided.

@AmirHmZz
Copy link
Owner

AmirHmZz commented Jan 13, 2023 •
edited
Loading

Do we need to add pyserial as dependency to pyproject.toml? As long as It is dependency of mpremote, I think there's no need to add it directly as dependency but we should specify version of mpremote.

@AmirHmZz AmirHmZz self-assigned this Jan 13, 2023
@AmirHmZz AmirHmZz added the enhancement New feature or request label Jan 13, 2023
@Wind-stormger
Copy link
Contributor Author

Any version of mpremote uses pyserial.
But I think it is right to add it.

@Wind-stormger @AmirHmZz
Implement list command
c7be7ac 
Co-Authored-By: Wind-stormger <76462385+Wind-stormger@users.noreply.github.com>
@AmirHmZz AmirHmZz merged commit 1068b3d into AmirHmZz:main Jan 13, 2023
@Wind-stormger Wind-stormger mentioned this pull request Jan 14, 2023
Closed
@AmirHmZz
Copy link
Owner

Thanks, available in version 1.3.2

@AmirHmZz AmirHmZz mentioned this pull request Jan 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AmirHmZz AmirHmZz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wind-stormger @AmirHmZz