Skip to content

Commit

Permalink
Provide better guidance around contributions & DCO (kedacore#720)
Browse files Browse the repository at this point in the history
* Add DCO to PR template with link to CONTRIBUTING

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Document how to fix unsigned commits

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
  • Loading branch information
tomkerkhove committed Apr 2, 2020
1 parent fac8478 commit e79249a
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 3 deletions.
10 changes: 8 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
<!-- Provide a description of what has been changed -->
<!-- Thank you for contributing!
Read more about how you can contribute in our contribution guide:
https://github.com/kedacore/keda/blob/master/CONTRIBUTING.md
-->

_Provide a description of what has been changed_

### Checklist

- [ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
- [ ] Commits are signed with Developer Certificate of Origin (DCO)
- [ ] Tests have been added


Fixes #
14 changes: 13 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ For any contribution you make that impacts the behavior or experience of KEDA, p

## Developer Certificate of Origin: Signing your work

**Every commit needs to be signed.**
### Every commit needs to be signed

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
```
Expand Down Expand Up @@ -56,3 +56,15 @@ $ git commit -s -m 'This is my commit message'
```

Each Pull Request is checked whether or not commits in a Pull Request do contain a valid Signed-off-by line.

### I didn't sign my commit, now what?!

No worries - You can easily replay your changes, sign them and force push them!

```
git checkout <branch-name>
git reset $(git merge-base master <branch-name>)
git add -A
git commit -sm "one commit on <branch-name>"
git push --force
```

0 comments on commit e79249a

Please sign in to comment.