Transforming LocalRepoFinder and QbtRemote classes. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These classes allow the user to map a repo to a different name locally on disk and on the server, allowing those places to use names which contain otherwise invalid characters for repo names. Resolves #5 and mitigates #4. QbtConfig might look like this: Function<String, String> transformNames = new Function<String, String>() { public String apply(String name) { return name.replace("flume_ng", "flume-ng").replace("hadoop_lzo", "hadoop-lzo"); } } return new QbtConfig( new TransformingFormatLocalRepoFinder(gitLocalVcs, transformNames, workspaceRoot.toString()), // ... new MapQbtRemoteFinder([ formatremote: new TransformingFormatQbtRemote( gitRemoteVcs, transformNames, "ssh://git@github.mtv.cloudera.com/TerabyteQbt/%r.git", ), githubremote: new TransformingGithubQbtRemote( gitRemoteVcs, transformNames, githubToken, "TerabyteQbt", "%r", ), ]), // ... );
terabyte
force-pushed
the
proposed-transforming-repos
branch
from
5459da2
to
6b177a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes allow the user to map a repo to a different name locally on disk
and on the server, allowing those places to use names which contain otherwise
invalid characters for repo names.
Resolves TerabyteQbt#5 and mitigates TerabyteQbt#4.
See commit message for example QbtConfig