Amna/combine pkgs #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects (optimizely#542) * feat: modify datafile managers to work with datafile string instead of object * fix: revert/discard unneeded changes that were accidentally pushed * test: update tests to comply with change in datafile format * fix: updated overlooked test case to ensure that TestDatafileManager was correctly created with a datafile string * style: fix linting * docs: update CHANGELOG unreleased changes * refactor: modify cache implementations to store values as a string instead of 'any' type and update corresponding tests * docs: update CHANGELOG unreleased changes to include changes to cache implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "why", or other context.
Test plan
Issues