Issue 261 and 263 #266
Issue 261 and 263 #266
Conversation
…andle using updated flag instead of deleted flag for projects that have newer versions. The find_one_project does not take that into account yet. This checkin is primarily to fix the serialization and desrialization of the previous_versions field which was being saved as an array, holding another array, holding a json dumped string representing an array of objects with date and id. now its just an array of objects with date and linkid (renamed so that it does not have to be trans-named every time its used).
- added new "current" field to db - integrate with Ted's changes for the string to array - get_one_project: added a check to find old IDs with current = False, to find and load old projects - changes to project.html template with ability to render old projects - changed _create project so previous versions list is directly loaded into it, inserts into DB once. NOTE: - edited projects will not set flag to delete anymore
There was a problem hiding this comment.
Behavior is not yet right. After versioning a project, its old versions still shows up in the private projects on the home page and profile page. They can also still be edited again so now you have a branching history [1->2->3, and also 1->2->2A]. Now when I go to the old original version 1 project page it does not give the banner of being an old project or show the newer versions in its history.
Also the find_one_project changes we discussed over slack.
Data in the MongoDB looks to be OK and otherwise the version project links seem to be working
- projects of previous versions no longer editable - changes to get_one_proj so it looks for a 'previous_version' project with current:false, delete:True - moved actual project deletion code to a new function called "admin_permanent_delete_project" - Changes to admin_delete_project: checks if previous versions exists in the project, if previous versions exists, then iterate through the previous versions and delete all of the previous versions. - Projects that are not current (current:false, a previous version of another project) will not show up on profile page anymore.
There was a problem hiding this comment.
Edwin, this looks good and my testing this morning did not turn up any errors or oddities. Good work!
One thing we should ask Jens is whether he anticipates a need to be able to revert to an older version (this was not in scope for 261/263) so in effect, a 'delete current version' button. Probably we don't need it though since you can always just make another new version with the file downloaded from the previous version and its unlikely to be a common action worth cluttering the UI.
|
@liefeld @edwin5588 - thank you for implementing this! Given the emerging importance of having a permalink (based on UUID) for projects, it is very likely we will need to have functionality to delete a specific version of a project, without deleting the entire history or making a new project (with a new UUID). |
To test:
OR
What I tested: