Updated variants/levels for Alert component #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinpiets
added
the
design-system-alignment
chrisvanmook
approved these changes
Oct 29, 2020
jonkoops
force-pushed
the
feature/alert-variants-updates-2
branch
from
6dbaba7 to
1243d6b
Compare
jonkoops
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Alert variants as discussed with @chrisvanmook and @jonkoops.
I created four levels (colors) and the option to set the color as outline (instead of the background)
Result:
Related issue: #1245
Related Trello card: https://trello.com/c/VyP5R53K/348-alerts-kleur-voorstel