Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update spacing in Ordered and Unordered List #1632

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Oct 7, 2024

Describe the pull request

While synchronizing figma variables with tokens the lack of space above a sublist became apparent. UX suggested the same amount of padding as the gap but didn't consider the line-height of the items. So I went with xs, and now it is visualy a little bit closer to the parent.

What

A rule for padding and a token for the child list of a ul or ol.

Why

It was cramped.

How

Just some CSS

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@VincentSmedinga VincentSmedinga changed the title feat: Ordered/Unordered list sub item gap feat: Add whitespace at the top of a nested Ordered or Unordered List Oct 8, 2024
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re also considering adding some whitespace at the bottom of the nested list. This PR can await that decision.

dlnr and others added 2 commits October 9, 2024 11:49
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
@github-actions github-actions bot temporarily deployed to demo-DES-965-sub-list-gap October 9, 2024 09:49 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-965-sub-list-gap October 9, 2024 09:52 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-965-sub-list-gap October 9, 2024 11:46 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-965-sub-list-gap October 9, 2024 11:49 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ve increased the space between items at level 1 to ams-space-md and applied the ams-space-sm to level 2.

I’ve added padding-block-end tokens for teams that want to reuse our list component.

@VincentSmedinga VincentSmedinga changed the title feat: Add whitespace at the top of a nested Ordered or Unordered List feat: Update whitespace at the top of a nested Ordered or Unordered List Oct 9, 2024
@VincentSmedinga VincentSmedinga changed the title feat: Update whitespace at the top of a nested Ordered or Unordered List feat: Update spacing in Ordered and Unordered List Oct 9, 2024
@VincentSmedinga VincentSmedinga merged commit 986e023 into develop Oct 9, 2024
8 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-965-sub-list-gap branch October 9, 2024 12:00
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants