-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update spacing in Ordered and Unordered List #1632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’re also considering adding some whitespace at the bottom of the nested list. This PR can await that decision.
proprietary/tokens/src/components/ams/unordered-list.tokens.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’ve increased the space between items at level 1 to ams-space-md
and applied the ams-space-sm
to level 2.
I’ve added padding-block-end
tokens for teams that want to reuse our list component.
Describe the pull request
While synchronizing figma variables with tokens the lack of space above a sublist became apparent. UX suggested the same amount of padding as the gap but didn't consider the line-height of the items. So I went with xs, and now it is visualy a little bit closer to the parent.
What
A rule for padding and a token for the child list of a ul or ol.
Why
It was cramped.
How
Just some CSS
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes