Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove form from Dialog #1582

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Sep 12, 2024

Describe the pull request

The form inside the dialog should be optional because there is a need to built larger forms in the popup. Besides that the vertical scroll (for long content) was broken by moving CSS to the dialog instead of the form wrapping the content. I've taking the liberty to recover some of that work but then rename the element: "form > content" and "actions > footer". The latter to illustrate that you are adding children to a (sticky) footer component.

What

Actions become footer and some changes in tokens.

Why

To allow developers to work with content other then <form method="dialog"> and to document how to use it if you want.

How

  • Rolling back the max-block-size in the dialog itself.
  • Removing the form element and adding it to a story.
  • Using a form attribute on the submit button when it's in the footer.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • I realise that making a row in the grid scrollable is weird but this is the most robust solution.

packages/react/src/Dialog/Dialog.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Dialog/Dialog.tsx Outdated Show resolved Hide resolved
storybook/src/components/Dialog/Dialog.docs.mdx Outdated Show resolved Hide resolved
storybook/src/components/Dialog/Dialog.docs.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-945-dialog-remove-form-2 September 13, 2024 13:22 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-945-dialog-remove-form-2 September 13, 2024 13:33 Destroyed
Co-authored-by: Aram <37216945+alimpens@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to demo-DES-945-dialog-remove-form-2 September 13, 2024 14:51 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-945-dialog-remove-form-2 September 13, 2024 15:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-945-dialog-remove-form-2 September 16, 2024 08:43 Destroyed
Co-authored-by: Aram <37216945+alimpens@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to demo-DES-945-dialog-remove-form-2 September 17, 2024 08:36 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat!: Remove Form in Dialog feat!: Remove form from Dialog Sep 17, 2024
@alimpens alimpens merged commit 4fb6e53 into develop Sep 17, 2024
7 checks passed
@alimpens alimpens deleted the feature/DES-945-dialog-remove-form-2 branch September 17, 2024 08:50
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants