Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Introduce Page Menu Item and Button #1663

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Oct 15, 2024

Describe the pull request

What

  • Extracts render of the li element from the PageMenu.Link subcomponent into a new PageMenu.Item subcomponent
  • Hides secondary Page Menu Items on narrow windows
  • Adds a PageMenu.Button subcomponent
  • Removes the wrap prop from PageMenu
  • Updates examples of other components using a Page Menu

Why

In preparation of the new Header and Mega Menu patterns.

How

Extracted from #1607.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant