-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce shades for brand colours #1748
Draft
VincentSmedinga
wants to merge
20
commits into
develop
Choose a base branch
from
feat/DES-1031-brand-color-tints
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-1031-brand-color-tints
November 11, 2024 14:31
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1031-brand-color-tints
November 11, 2024 15:17
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1031-brand-color-tints
November 11, 2024 15:36
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1031-brand-color-tints
November 12, 2024 15:33
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1031-brand-color-tints
November 12, 2024 15:57
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1031-brand-color-tints
November 13, 2024 14:47
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
This introduces tokens for a lighter (tint) and a darker shade for each base colour in a new namespace
ams.brand.color
. All components have been updated to use the new tokens.Why
Our colour palette was too small – various components need variations. Our ‘fake’ dark blue is now a shade of the ‘real’ blue. We have a hover shade for red now, as well.
How
The palettes were designed in Figma. The colour values have been copied over as new tokens. The documentation page has been updated.