Fix for footer link list markup and hover style #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SireeKoolenWijkstra
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Looks good, does what it needs to do. I've got two questions:
- I get a warning and I think it is on line 72 of index.tsx of Footer a header is inside the paragraph. I think we actually can just remove this paragraph and heading? Since you're touching it, maybe you want to? (or is this again a case of keep your stories as small as possible?)
- Why do we still need a LinkList from the Design System? I think we overwritten their default behaviour so why is that still nice to have?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On light mode - the footer links have different hover styling (because one is an external link and the other internal router link). This fixes that.