MIJN-9702-CHORE/BAG-endpoint-vervangen-ivm-deprecation-huidig-endpoint #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoanPaulus
requested review from
timvanoostrom,
OscarBakker and
TerryvanWalen
RoanPaulus
force-pushed
the
MIJN-9702-CHORE/BAG-endpoint-vervangen-ivm-deprecation-huidig-endpoint
branch
4 times, most recently
from
c34bcd4 to
48cb931
Compare
RoanPaulus
force-pushed
the
MIJN-9702-CHORE/BAG-endpoint-vervangen-ivm-deprecation-huidig-endpoint
branch
from
2504892 to
825e877
Compare
timvanoostrom
requested changes
Dec 19, 2024
| @@ -21,39 +18,35 @@ export async function fetchBAG( | |||
| requestID: RequestID, | |||
| sourceAddress: Adres | null | |||
| ) { | |||
There was a problem hiding this comment.
Explicit return type mist
src/server/services/bag.ts
Outdated
| const isWeesp = sourceAddress.woonplaatsNaam === 'Weesp'; | ||
| const data = responseData._embedded?.adresseerbareobjecten; | ||
| if (!data || data.length < 1) { | ||
| return {}; |
There was a problem hiding this comment.
Liever null teruggeven
Co-authored-by: Tim van Oostrom <t.van.oostrom@amsterdam.nl>
Co-authored-by: Tim van Oostrom <t.van.oostrom@amsterdam.nl>
Co-authored-by: Tim van Oostrom <t.van.oostrom@amsterdam.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.