Skip to content

Commit

Permalink
[feat-6283]: Update dependencies (#3023)
Browse files Browse the repository at this point in the history
* Delete 3 unused NPM Dependencies

* Remove Sentry (not in use)

* update package-lock.json

* Revert removal of Sentry in ADR, they're immutable

* Restore and update the lockfile, instead of deleting it

* Remove unnecessary next call

* Remove unnecessary next calls

---------

Co-authored-by: alimpens <a.limpens@amsterdam.nl>
  • Loading branch information
Doilee and alimpens authored Dec 9, 2024
1 parent 2c4fece commit 785e71b
Show file tree
Hide file tree
Showing 18 changed files with 2 additions and 377 deletions.
2 changes: 0 additions & 2 deletions .github/review/values.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,3 @@ config:
realm: datapunt-ad-acc
responseType: code
scope: openid
sentry:
dsn: https://3de59e3a93034a348089131aa565bdf4@sentry-new.data.amsterdam.nl/27
3 changes: 0 additions & 3 deletions app.amsterdam.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,6 @@
"responseType": "code",
"scope": "openid"
},
"sentry": {
"dsn": "https://3de59e3a93034a348089131aa565bdf4@sentry-new.data.amsterdam.nl/27"
},
"azure": {
"connectionString": "InstrumentationKey=c39a786a-82ac-471d-a0c6-feb41eb4967b;IngestionEndpoint=https://westeurope-5.in.applicationinsights.azure.com/;LiveEndpoint=https://westeurope.livediagnostics.monitor.azure.com/"
}
Expand Down
16 changes: 0 additions & 16 deletions internals/schemas/app.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
"oidc": {
"$ref": "#/definitions/Oidc"
},
"sentry": {
"$ref": "#/definitions/Sentry"
},
"azure": {
"$ref": "#/definitions/Azure"
},
Expand Down Expand Up @@ -733,19 +730,6 @@
"required": ["attribution", "tms"],
"title": "TilesOptions"
},
"Sentry": {
"type": "object",
"additionalProperties": false,
"properties": {
"dsn": {
"type": "string",
"format": "uri",
"description": "Sentry data source name value. When omitted, Sentry will not be initialised in the application"
}
},
"required": ["dsn"],
"title": "Sentry"
},
"Azure": {
"type": "object",
"additionalProperties": true,
Expand Down
Loading

0 comments on commit 785e71b

Please sign in to comment.