[chore-5471]: Change label color with newDesignDystem prop #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/Label/Label.test.tsx
Outdated
| </Fragment> | ||
| ) | ||
| ) | ||
|
|
||
| expect(screen.getByText('Label 1')).not.toHaveStyleRule('color', 'inherit') | ||
| expect(screen.getByText('Label 2')).toHaveStyleRule('color', 'inherit') | ||
| expect(screen.getByText('Label 2')).toHaveStyleRule('color', 'inherit') |
There was a problem hiding this comment.
Shouldn't this be label 3 ?
|
|
||
| interface LabelProps { | ||
| /** When true, will render the label with a plain font instead of a bold font */ | ||
| inline?: boolean | ||
| /** When false, the Label component will render as an inline-block element without the red header colour */ | ||
| isGroupHeader?: boolean | ||
| /** when true, a label is also black when rendered as group header */ | ||
| isNewDesignSystem?: boolean |
There was a problem hiding this comment.
Will this be removed at some time in the future? Because the name (is NewDesignSystem) doesn't clue me in about group headers and that it's used for that. Right now I'm thinking this has something to do with the NL design styling.
There was a problem hiding this comment.
True. I referred to the new design system for now.
OscarBakker
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SIG-5471
Changing color labels when design according to new design system