Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure Sigmax return state #1466

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bartjkdp
Copy link
Contributor

@bartjkdp bartjkdp commented Sep 8, 2024

Description

This PR makes it possible to configure the Sigmax return state. Currently the status in Signalen always returns to "done external" (Extern: afgehandeld), but some municipalities would like to be able to set the status to "o" (Afgehandeld).

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations
  • PR was created with the "Allow edits and access to secrets by maintainers" checkbox checked

How has this been tested?

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 85% (the higher the better)
  • No iSort, Flake8 and SPDX issues are present in the code

@bartjkdp bartjkdp force-pushed the feat/configurable-sigmax-return-state branch 3 times, most recently from 75edebc to 1c886a4 Compare September 9, 2024 14:33
@bartjkdp bartjkdp force-pushed the feat/configurable-sigmax-return-state branch 2 times, most recently from ffd72a0 to 8ab4d08 Compare October 8, 2024 17:24
@bartjkdp
Copy link
Contributor Author

bartjkdp commented Oct 8, 2024

We are currently testing this change in Leiden.

@bartjkdp bartjkdp force-pushed the feat/configurable-sigmax-return-state branch from 8ab4d08 to 73808aa Compare October 21, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant