Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds possibility to add signalering to sigmax description if specific… #1487

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

ramonavic
Copy link
Contributor

… source is provided

Description

Add a meaningful description explaining the change/fix that is provided in this PR

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations
  • PR was created with the "Allow edits and access to secrets by maintainers" checkbox checked

How has this been tested?

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 85% (the higher the better)
  • No iSort, Flake8 and SPDX issues are present in the code

@ramonavic ramonavic marked this pull request as ready for review January 27, 2025 12:38
@ramonavic ramonavic merged commit 1db11a5 into main Jan 27, 2025
3 checks passed
@ramonavic ramonavic deleted the feat-6367/pass-signalering-on-source branch January 27, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants