Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-empty .http files sometimes open without a cell #33

Closed
dlucazeau opened this issue Oct 21, 2021 · 7 comments
Closed

Non-empty .http files sometimes open without a cell #33

dlucazeau opened this issue Oct 21, 2021 · 7 comments

Comments

@dlucazeau
Copy link

Hello,
If I open them normally, I see a single empty cell, whereas if I open them as a text file I see the non-empty content:
2021-10-21_10-02-11

Some .http files open correctly. It seems to me that they are always the same ones that open well or that open badly.
How to isolate the problem and correct it.

Version: 1.61.2 (user setup)
Commit: 6cba118ac49a1b88332f312a8f67186f7f3c1643
Date: 2021-10-19T14:57:20.575Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

@AnWeber
Copy link
Owner

AnWeber commented Oct 21, 2021

I had already observed the error once myself. But closing the editor and opening it again was enough for me. However, I have not yet been able to reproduce it or determine the cause.
I will install an additional logging to possibly find the cause. Unfortunately the NotebookSerializer interface does not use a filename and this complicates the search, but also the loading logic.

@AnWeber
Copy link
Owner

AnWeber commented Oct 24, 2021

I have now set the LogLevel in case of error to Error, so that it is easier to get the log. This is shown in the output under channel httpyac - Log. Unfortunately I could not produce the error now. If you can repdroduce it, it would be great if you attach it to the issue.

@AnWeber
Copy link
Owner

AnWeber commented Oct 25, 2021

seems to be this error

ERROR: Unavailable (FileSystemError) - No file system provider found for resource 'vscode-notebook-cell:/c%3A/git/postman/src/actuator#ch0000000'
Unavailable (FileSystemError): No file system provider found for resource 'vscode-notebook-cell:/c%3A/git/postman/src/actuator#ch0000000'
	at _handleError (c:\Users\weber.DODAV\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:94:163663)
	at runMicrotasks (<anonymous>)
	at processTicksAndRejections (internal/process/task_queues.js:93:5)

I feel old, did not remember that: microsoft/vscode#124530

@AnWeber
Copy link
Owner

AnWeber commented Oct 25, 2021

The reason is that I assumed that the order of opening a notebook is different. I thought first the active editor is set and then the file is parsed. Instead the content of the file is determined and then the editor is created. As a result, an error occurs because the URI is only a virtual Uri, I have interpreted as file Uri. The simple fix is to not use the Uri and only put it on the correct Uri when executing.

@AnWeber
Copy link
Owner

AnWeber commented Oct 25, 2021

I have published the version. Could you please test it. Thank you.

@dlucazeau
Copy link
Author

The behavior seems to me correct on some file openings that were in anomaly before this version.

Thanks a lot for this correction.

@AnWeber
Copy link
Owner

AnWeber commented Oct 27, 2021

Thanks for the response.

@AnWeber AnWeber closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants