Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: uncaught ECONNREFUSED errors causing runtime errors without bail flag #708

Closed
mmadson opened this issue Jun 2, 2024 · 1 comment

Comments

@mmadson
Copy link

mmadson commented Jun 2, 2024

Continued from discussion in #705

Expected: if server refuses an http connection for an httpyac client request, the http region / test should be reported as a failure in the test report / output but should continue on to execute the next http region / test until all tests have been executed -- unless of course the --bail cli flag is provided in which case, propagating the error and terminating the test suite early is the desired behavior.

Actual: if server refuses an http connection for an httpyac client request, test execution terminates early and the ECONNREFUSED error is propagated regardless of whether the bail flag is supplied or not.

AnWeber added a commit that referenced this issue Aug 4, 2024
AnWeber added a commit to AnWeber/vscode-httpyac that referenced this issue Aug 4, 2024
@AnWeber
Copy link
Owner

AnWeber commented Aug 4, 2024

I have now restructured it once so that the exceptions only affect the respective httpRegion. This means that I had to revise the handling for ExitCode and bail. I should have tested everything thoroughly, but this could still lead to unexpected conflicts. But I agree with you that the behavior for tests is not optimal and that your desired behavior should be implemented here. I will release it with the next release

@AnWeber AnWeber closed this as completed Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants