Edit the README but not the CHANGELOG #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After using the PR template for a while, I think simplifying it will be helpful: - GitHub includes the commit message description automatically with the aim of saving you time as it is sometimes also a good PR description. With the current template, I need to cut this test and paste it into the description section (which is really annoying!). - Make a single simpler checklist. Add information as comment and have a straightforward list which helps us remembering the changelog, tests and documentation without needing to invest much time. The changelog bulletpoint will also be used in GitHub Actions.
Request changes in a PR without CHANGELOG update.
`Ana06/automatic-pull-request-review@v0.1.0` is a fork of https://github.com/AndrewMusgrave/automatic-pull-request-review which fixes `DISMISS` and provides an `allow_duplicate` option which allows to only approve once.
Ana06/get-changed-files@v1.1 is a fork of https://github.com/jitterbit/get-changed-files, which supports `pull_request_target` and allow to filter files using regular expressions. As we need to use `pull_request_target`, Ana06/get-changed-files@v1.1 works, but jitterbit/get-changed-files@v1 doesn't.
Doing evil. 😈
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think it is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
3 tasks
Ana06
force-pushed
the
master
branch
2 times, most recently
from
bef6797 to
16d39e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing evil. 😈
Checklist