Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg 4785 2.0.1.2 initial #1

Merged
merged 7 commits into from
May 20, 2024
Merged

Pkg 4785 2.0.1.2 initial #1

merged 7 commits into from
May 20, 2024

Conversation

danpetry
Copy link

@danpetry danpetry commented May 16, 2024 •
edited by jira bot
Loading

Destination channel: defaults

Links

Explanation of changes:

  • Part of CUDA 12.4 build, following conda-forge's pattern which was developed in conjunction with Nvidia. I don't see a need to stage these then release them all at once. They won't cause a problem released one at a time.
  • Please check the main branch too, this has just been forked
  • Changes made to adjust feedstock for differences between conda-forge and defaults. Please see commit messages for description of changes.

@danpetry
Remove conda-forge build requirement on specific arm architecture
cc7ceb6 
We don't have arm-variant as a package in defaults.

It's left in run_constrained to support compatibility when mixed with

conda-forge packages.
@danpetry
Adjust supported glibc version on linux-aarch64; it's different from …
195a459 
…conda-forge's
@danpetry
Skip s390x, it's unsupported by CUDA
b2c6f0d
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_c69zyrgev7/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:95: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:96: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:55: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

@danpetry danpetry changed the title vim Pkg 4785 2.0.1.2 initial Pkg 4785 2.0.1.2 initial May 16, 2024
@danpetry
Changes because we don't build a matrix like conda-forge, just one ve…
0f8fde4 
…rsion.

Remove restriction on cuda_compiler_version and change cuda-version pin

Add comment that this doesn't need to be rebuilt for every cuda version (because this is now compatible with all 12.x)
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_59q4ofy8jf/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:98: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:99: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:58: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:98: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:99: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    2 Errors and 3 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_157lkkdlhy/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:98: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:99: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:58: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:98: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:99: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    2 Errors and 3 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_515yhjo5c1/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:98: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:58: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:99: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:98: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:99: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    2 Errors and 3 Warnings were found

skupr-anaconda
skupr-anaconda approved these changes May 20, 2024
View reviewed changes
Copy link

@skupr-anaconda skupr-anaconda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if git on win64 is acceptable

recipe/meta.yaml Show resolved Hide resolved
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d8x71d96j8/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:58: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:99: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:98: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:99: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:98: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    2 Errors and 3 Warnings were found

@danpetry danpetry merged commit 17c6329 into main May 20, 2024
6 of 8 checks passed
@danpetry danpetry deleted the PKG-4785-12.4-initial branch May 20, 2024 15:49
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_66xyybh22j/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:99: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:98: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:58: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:99: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:98: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    2 Errors and 3 Warnings were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skupr-anaconda skupr-anaconda skupr-anaconda approved these changes

@psteyer psteyer psteyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danpetry @anaconda-pkg-build @psteyer @skupr-anaconda