Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial build for file feedstock #1

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

JeanChristopheMorinPerso
Copy link

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Feb 8, 2024

file+libmagic 5.39

Destination channel: defaults

Links

Explanation of changes:

Our current libmagic lives in https://github.com/AnacondaRecipes/libmagic-feedstock. conda-forge archived their repo and moved it to https://github.com/conda-forge/file-feedstock.

This PR does exactly this.

We needed to build libmagic 5.39 on all platforms (for consistency).

Things to review are the feedstock, and the build number. Since we already have 5.39 on defaults, it's important that we don't override it by mistake.

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_405f1gvl9r/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:82: missing_description: The recipe is missing a description

===== ERRORS =====

  • clone/recipe/meta.yaml:10: invalid_url: ftp://ftp.astron.com/pub/file/file-5.39.tar.gz : No connection adapters were found for 'ftp://ftp.astron.com/pub/file/file-5.39.tar.gz'
    ===== Final Report: =====
    1 Error and 1 Warning were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_9al0qqv8cy/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:86: missing_description: The recipe is missing a description

===== ERRORS =====

  • clone/recipe/meta.yaml:10: invalid_url: ftp://ftp.astron.com/pub/file/file-5.39.tar.gz : No connection adapters were found for 'ftp://ftp.astron.com/pub/file/file-5.39.tar.gz'
    ===== Final Report: =====
    1 Error and 1 Warning were found

Copy link

@SC426 SC426 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would add a description if possible.

Copy link

@ViridianMelody ViridianMelody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit aab8c1e into master Feb 12, 2024
7 of 8 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the PKG-4029_5.39 branch February 12, 2024 17:36
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_82oiwkvab_/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:86: missing_description: The recipe is missing a description

===== ERRORS =====

  • clone/recipe/meta.yaml:10: invalid_url: ftp://ftp.astron.com/pub/file/file-5.39.tar.gz : No connection adapters were found for 'ftp://ftp.astron.com/pub/file/file-5.39.tar.gz'
    ===== Final Report: =====
    1 Error and 1 Warning were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants