Update 3.7.7 #13
Merged
Update 3.7.7 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arishamays1
commented
Nov 13, 2024
•
Arishamays1
commented
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_59d_go0fhv/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_9883msne79/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
Linter check found the following problems:Traceback (most recent call last): File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/run.py", line 208, in main return_code, report = execute_linter( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/run.py", line 180, in execute_linter result = linter.lint(recipes, subdir, variant_config_files, exclusive_config_files, fix_flag) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 725, in lint msgs = self.lint_file( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 823, in lint_file recipe = _recipe.Recipe.from_file( ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/render/recipe.py", line 243, in from_file raise exc from exc File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/render/recipe.py", line 234, in from_file recipe._load_from_string(text.read()) File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/render/recipe.py", line 170, in _load_from_string self.render() File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/render/recipe.py", line 290, in render self.meta = renderer_utils.render(self.recipe_dir, self.dump(), self.selector_dict, self.renderer) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/render/_renderer.py", line 245, in render return ruamel.load(yaml_text.replace("\t", " ").replace("%", " ")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/main.py", line 451, in load return constructor.get_single_data() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/constructor.py", line 114, in get_single_data node = self.composer.get_single_node() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 72, in get_single_node document = self.compose_document() ^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 94, in compose_document node = self.compose_node(None, None) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 130, in compose_node node = self.compose_mapping_node(anchor) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 211, in compose_mapping_node item_value = self.compose_node(node, item_key) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 130, in compose_node node = self.compose_mapping_node(anchor) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 211, in compose_mapping_node item_value = self.compose_node(node, item_key) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 128, in compose_node node = self.compose_sequence_node(anchor) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/composer.py", line 172, in compose_sequence_node while not self.parser.check_event(SequenceEndEvent): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/parser.py", line 141, in check_event self.current_event = self.state() ^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/parser.py", line 535, in parse_block_sequence_entry if self.scanner.check_token(BlockEntryToken): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/scanner.py", line 1733, in check_token while self.need_more_tokens(): ^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/scanner.py", line 203, in need_more_tokens self.stale_possible_simple_keys() File "/opt/conda/envs/linter/lib/python3.12/site-packages/ruamel/yaml/scanner.py", line 348, in stale_possible_simple_keys raise ScannerError( ruamel.yaml.scanner.ScannerError: while scanning a simple key in "", line 20, column 1: requirements:; ^ (line: 20) could not find expected ':' in "", line 21, column 8: build: ^ (line: 21)ERROR conda.cli.main_run:execute(125): |
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_9e62zzbkhp/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
bwingconda
reviewed
Nov 14, 2024
recipe/patches/0009-CMake-Force-Multi-threaded-DLL-runtime.patch
Outdated
Show resolved
Hide resolved
|
Can you revert the changes to the patches? It seems line endings have been modified. |
|
I just saw this ticket related: https://anaconda.atlassian.net/browse/PKG-5733 |
|
Or we could undo libarchive/libarchive#1976 for this update. And wait for a 3.8 release to switch to the new soname. |
This is fine! I can put this on hold for now and follow up on it if that works! |
|
@cbouss however painful the ABI break might be, I think we need to do it now. I don't know when 3.8 will come out and it might not even happen. This ABI breakage is a big problem that causes a bunch of issues between us and conda-forge which in itself breaks conda (or more libmamba, which breas conda-libmamba-solver which breaks conda). I really think we should align with conda-forge here. |
|
ABI breakage addressed by AnacondaRecipes/repodata-hotfixes#244 |
Jrice1317
approved these changes
Dec 11, 2024
ELundby45
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.