-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Py Dep #3
Conversation
Linter check found the following problems:The following problems have been found:WARNING: clone/recipe/meta.yaml:48: missing_description: The recipe is missing a description |
Linter check found the following problems:The following problems have been found:WARNING: clone/recipe/meta.yaml:48: missing_description: The recipe is missing a description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -26,6 +26,7 @@ requirements: | |||
- python | |||
- pytest >=3.8 | |||
- py-cpuinfo | |||
- py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- py |
It doesn't rely on py
anymore. See:
- Compatibility issue with pytest 7.2: Package
py
is used but not listed as dependency ionelmc/pytest-benchmark#226 - ionelmc/pytest-benchmark@c2e860f
- https://github.com/ionelmc/pytest-benchmark/blob/v4.0.0/setup.py#L69-L71
- https://github.com/ionelmc/pytest-benchmark/blob/7ef2645ae76dfd7a5928ae552fc7f5b955616074/src/pytest_benchmark/cli.py#L4-L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here they seem to still be requiring it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They rely on py.path.local
only so there can be a way to patch the package to use pytest's py
iplementetion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be safer to keep it in now, remove the pytest
hotfix, and remove it in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Linter check found the following problems:The following problems have been found:WARNING: clone/recipe/meta.yaml:48: missing_description: The recipe is missing a description |
Adding Py dependency see following Jira ticket for more information:
https://anaconda.atlassian.net/browse/CVE-566
changes
py