Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Py Dep #3

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Adding Py Dep #3

merged 2 commits into from
Oct 27, 2023

Conversation

psteyer
Copy link

@psteyer psteyer commented Oct 20, 2023

Adding Py dependency see following Jira ticket for more information:
https://anaconda.atlassian.net/browse/CVE-566

changes

  • adding py
  • bumping build #

@psteyer psteyer self-assigned this Oct 20, 2023
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

WARNING: clone/recipe/meta.yaml:48: missing_description: The recipe is missing a description
Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

WARNING: clone/recipe/meta.yaml:48: missing_description: The recipe is missing a description
Warnings were found

Copy link

@ryanskeith ryanskeith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -26,6 +26,7 @@ requirements:
- python
- pytest >=3.8
- py-cpuinfo
- py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They rely on py.path.local only so there can be a way to patch the package to use pytest's py iplementetion

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be safer to keep it in now, remove the pytest hotfix, and remove it in the future?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@psteyer psteyer merged commit 1f2a74e into master Oct 27, 2023
8 of 9 checks passed
@psteyer psteyer deleted the adding-py branch October 27, 2023 17:37
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

WARNING: clone/recipe/meta.yaml:48: missing_description: The recipe is missing a description
Warnings were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants