Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAV-998: navigator-related dependency conflicts #208

Merged
merged 1 commit into from
Oct 3, 2023
Merged

NAV-998: navigator-related dependency conflicts #208

merged 1 commit into from
Oct 3, 2023

Conversation

yshmatov-anaconda
Copy link
Contributor

Issues fixed in this PR:

  • some anaconda-navigator features don't work on conda=23.7.3
  • anaconda-navigator may fail due to missing jaraco.classes imported from anaconda-cloud-auth

mattkram
mattkram approved these changes Oct 3, 2023
View reviewed changes
Copy link

@mattkram mattkram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anaconda-cloud-auth dependency LGTM. I can't comment authoritatively on the other one.

main.py
@@ -925,6 +925,10 @@ def patch_record_in_place(fn, record, subdir):
):
depends.append("_low_priority")

if name == 'anaconda-cloud-auth':
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryanskeith
ryanskeith approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ryanskeith ryanskeith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me.

@ryanskeith ryanskeith merged commit 64ba439 into AnacondaRecipes:master Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanskeith ryanskeith ryanskeith approved these changes

@mattkram mattkram mattkram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yshmatov-anaconda @ryanskeith @mattkram