Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowflake-ml-python 1.6.2 #36

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Conversation

psteyer
Copy link
Contributor

@psteyer psteyer commented Sep 16, 2024

@psteyer psteyer marked this pull request as ready for review September 17, 2024 12:13
@ifitchet
Copy link

doc_url: pyproject.toml says one thing which redirects to the same place that your value redirects to: https://docs.snowflake.com/developer-guide/snowflake-ml/overview -- obviously, double check! 😄

Copy link
Contributor

@boldorider4 boldorider4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ifitchet
Copy link

Reading my own code's output a bit more closely:

feedstock-tool: +112s: WARNING:  README.md looks a bit short 

It gives a suggestion.

feedstock-tool: +112s: WARNING:  CODEOWNERS not set 
mkdir -p .github
echo @AnacondaRecipes/psubs > .github/CODEOWNERS

Also, pyproject.toml is only in the pypi tarball.

Copy link
Contributor

@lorepirri lorepirri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set the build number to 100 update the pinning of xgboost>=1.7.3,<2.1, add codeowner as in previous version and recurrent packages.

You can spot as the only change in the diff with the previous version that we have and search for ci/conda_recipe/meta.yaml and requirements.yml.

snowflakedb/snowflake-ml-python@1.6.1...1.6.2

@lorepirri lorepirri requested a review from a team September 18, 2024 07:05
skupr-anaconda
skupr-anaconda previously approved these changes Sep 18, 2024
@skupr-anaconda skupr-anaconda dismissed their stale review September 18, 2024 08:13

osx-arm64 failed

@lorepirri
Copy link
Contributor

osx-arm64 fails because of this pypa/pip#12884 see internal discussion https://anaconda.slack.com/archives/C04QPV5GWBW/p1726643593008439

psteyer and others added 3 commits September 18, 2024 06:03
Co-authored-by: Lorenzo Pirritano <6698585+lorepirri@users.noreply.github.com>
…ndaRecipes/snowflake-ml-python-feedstock into PKG-5713_snowflake-ml-python_1.6.2
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_91zpjc1lbz/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

  • clone/recipe/meta.yaml:98: missing_test_requirement_pip: pip is required in the test requirements.
    ===== Final Report: =====
    1 Error and 0 Warnings were found

Co-authored-by: Lorenzo Pirritano <6698585+lorepirri@users.noreply.github.com>
Copy link
Contributor

@lorepirri lorepirri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the improvements done!

@lorepirri
Copy link
Contributor

@boldorider4 I think your suggestions were addressed

@psteyer psteyer merged commit 82e8c54 into main Sep 18, 2024
8 checks passed
@psteyer psteyer deleted the PKG-5713_snowflake-ml-python_1.6.2 branch September 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants