Address pr changes

AnalogIO · Feb 13, 2024 · ff2b7cc · ff2b7cc
1 parent 5028b8d
commit ff2b7cc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/coffeecard/CoffeeCard.Library/Services/v2/MenuItemService.cs b/coffeecard/CoffeeCard.Library/Services/v2/MenuItemService.cs
@@ -80,8 +80,9 @@ public async Task<MenuItemResponse> UpdateMenuItemAsync(int id, UpdateMenuItemRe
                 throw new ConflictException($"Menu item already exists with name {changedMenuItem.Name}");
             }
 
-            if (!changedMenuItem.Active &&
-                await _context.Products.AnyAsync(p => p.EligibleMenuItems.Any(menuItem => menuItem.Id == id)))
+
+            var menuItemIsUsed = await _context.Products.AnyAsync(p => p.EligibleMenuItems.Any(menuItem => menuItem.Id == id));
+            if (!changedMenuItem.Active && menuItemIsUsed)
             {
                 throw new ConflictException("Menu item is in use and cannot be disabled");
             }