Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct where clause in resend verification #204

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

duckth
Copy link
Member

@duckth duckth commented Sep 14, 2023

According to this article from the EF Core docs, using the StringComparison enum in Equals does not correctly translate to SQL, and as such EF Core will throw an exception.

This pull request changes the Where clause to simply perform .ToLower() on each string, to ensure case-insensitivity

@duckth duckth requested a review from jonasanker September 14, 2023 10:42
@duckth duckth self-assigned this Sep 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ghost
Copy link

ghost commented Sep 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@duckth duckth requested a review from marfavi September 14, 2023 11:08
Copy link
Member

@marfavi marfavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Please verify that the solution works after merge

@duckth duckth merged commit 051e0b7 into develop Sep 14, 2023
7 checks passed
@duckth duckth deleted the fix/atro/fix-resend-verification branch September 14, 2023 11:10
duckth added a commit that referenced this pull request Sep 14, 2023
* Use api version as part of route in accontAController v2 (#198)

* Change route to use api version

* Revert change to url in register endpoint response (#201)

* Anti :cowboy: -measures (#202)

* fix: Correct where clause in resend verification (#204)

---------

Co-authored-by: Frederik Petersen <43568735+fredpetersen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants