Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the responsetype of getProducts #220

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fixed the responsetype of getProducts #220

merged 2 commits into from
Nov 2, 2023

Conversation

TTA777
Copy link
Member

@TTA777 TTA777 commented Nov 2, 2023

No description provided.

@TTA777 TTA777 requested a review from fredpetersen November 2, 2023 18:13
@TTA777 TTA777 enabled auto-merge (squash) November 2, 2023 18:13
fredpetersen
fredpetersen approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@fredpetersen fredpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c33d3b) 7.90% compared to head (9e4bc36) 7.90%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop    #220   +/-   ##
=======================================
  Coverage     7.90%   7.90%           
=======================================
  Files          163     163           
  Lines        10129   10129           
  Branches       461     461           
=======================================
  Hits           801     801           
  Misses        9310    9310           
  Partials        18      18
Files Coverage Δ
...eeCard.WebApi/Controllers/v2/ProductsController.cs 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Nov 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TTA777 TTA777 merged commit daed7ca into develop Nov 2, 2023
7 checks passed
@TTA777 TTA777 deleted the fix/getProductsResponseType branch November 2, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredpetersen fredpetersen fredpetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TTA777 @codecov-commenter @fredpetersen @marfavi