Feature/issue vouchers #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Guldborg
force-pushed
the
feature/issue-vouchers
branch
from
681556f to
2d458b0
Compare
jonasanker
reviewed
Oct 21, 2023
A-Guldborg
force-pushed
the
feature/issue-vouchers
branch
from
686ac63 to
a2128a6
Compare
|
@marfavi will you review at least my last commit, as I have implemented your two UX suggestions as discussed: A counter showing how many letters I have written´ |
marfavi
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
This PR adds a UI for generating vouchers.
This uses a repository pattern to abstract the data layer.
Uses Snackbars to indicate errors
Uses info from logged-in account as requester and voucher-prefix.
Adds validation to the MudForm element to enable/disable submit button.
To-do list: